Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extraMounts and volumes to migrate job #147

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

wenzel-felix
Copy link
Contributor

@wenzel-felix wenzel-felix commented Jul 18, 2024

This PR adds the extraVolumes and extraVolumeMounts to the migration job.

Description

As this PR (#142) also already did, I added extraVolumes and extraVolumeMounts to the migrate job allowing for different scenarios not possible without, eg. mounting CA bundles or mounting secrets via SPC for the database credentials to be used by the job.

Compared to the other PR I also added the default values in the values.yaml and added the new values to the validation schema.

References

#142

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@wenzel-felix wenzel-felix requested review from a team as code owners July 18, 2024 16:55
Copy link

linux-foundation-easycla bot commented Jul 18, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@wenzel-felix
Copy link
Contributor Author

Hi @rhamzeh / @jon-whit , sorry for asking again, but could you review the changes?
These are very minor additions to the migration hook job.

Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @wenzel-felix - apologies for the delay in the review!

@rhamzeh rhamzeh enabled auto-merge (squash) August 7, 2024 11:42
@rhamzeh rhamzeh merged commit 2e7eec9 into openfga:main Aug 7, 2024
4 checks passed
@wenzel-felix wenzel-felix mentioned this pull request Aug 7, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants