Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Playground should disable if playground.enabled=false #55

Merged
merged 1 commit into from
Jul 31, 2023
Merged

fix: Playground should disable if playground.enabled=false #55

merged 1 commit into from
Jul 31, 2023

Conversation

jon-whit
Copy link
Collaborator

@jon-whit jon-whit commented Jul 31, 2023 •
edited
Loading

Description

If playground.enabled=false then we shouldn't omit the env variable since the Playground is enabled by default in the OpenFGA server. This makes sure that we set the env variable to true/false regardless of its value.

References

Closes #54

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@jon-whit jon-whit merged commit 5d31e85 into main Jul 31, 2023
@jon-whit jon-whit deleted the fix-playground-setting branch July 31, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpadilla jpadilla jpadilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Playground Not Disabled When Setting playground.enabled: false
2 participants
@jon-whit @jpadilla