Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating HorizontalPodAutoscalar #67

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Updating HorizontalPodAutoscalar #67

merged 1 commit into from
Oct 9, 2023

Conversation

jliedy
Copy link
Contributor

@jliedy jliedy commented Oct 9, 2023

In support of correcting issue #65 I've updated the HPA API version and corrected the spec structure.

Description

Updated the apiVersion to autoscalingv2
Updated .spec.metrics.type[*].resource to use .target structure

References

Pull is based on correcting issue #65
The reference for the API version being deprecated can be found at https://kubernetes.io/docs/reference/using-api/deprecation-guide/#horizontalpodautoscaler-v125
The reference for the spec change can be found at https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/#support-for-resource-metrics

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@jliedy
Copy link
Contributor Author

jliedy commented Oct 9, 2023

I bumped the chart and app version to play nice with pull request #66 and/or #63

@jon-whit
Copy link
Collaborator

jon-whit commented Oct 9, 2023

@jliedy mind rebasing on main? We just merged some changes.

@jliedy jliedy closed this Oct 9, 2023
@jliedy
Copy link
Contributor Author

jliedy commented Oct 9, 2023

One sec

Added spec changes

Signed-off-by: Jonathan Liedy <jliedy@gmail.com>
@jliedy
Copy link
Contributor Author

jliedy commented Oct 9, 2023

That should do it.

@jliedy jliedy reopened this Oct 9, 2023
@jon-whit jon-whit merged commit cc00a6a into openfga:main Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants