Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for consistency parameter #107

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

jimmyjames
Copy link
Contributor

Description

Adds support for the consistency parameter for those endpoints that support it (read, check, list objects, list users, expand).

In addition to the updated unit tests, I also tested against a live server and verified it is working as expected.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 52.70270% with 70 lines in your changes missing coverage. Please review.

Project coverage is 31.70%. Comparing base (0b7e643) to head (5f42012).

Files Patch % Lines
...java/dev/openfga/sdk/api/client/OpenFgaClient.java 67.64% 3 Missing and 8 partials ⚠️
...n/java/dev/openfga/sdk/api/model/CheckRequest.java 28.57% 10 Missing ⚠️
.../java/dev/openfga/sdk/api/model/ExpandRequest.java 28.57% 10 Missing ⚠️
.../dev/openfga/sdk/api/model/ListObjectsRequest.java 28.57% 10 Missing ⚠️
...va/dev/openfga/sdk/api/model/ListUsersRequest.java 28.57% 10 Missing ⚠️
...in/java/dev/openfga/sdk/api/model/ReadRequest.java 28.57% 10 Missing ⚠️
...v/openfga/sdk/api/model/ConsistencyPreference.java 58.82% 7 Missing ⚠️
...sdk/api/configuration/ClientBatchCheckOptions.java 85.71% 1 Missing ⚠️
.../api/configuration/ClientListRelationsOptions.java 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #107      +/-   ##
============================================
+ Coverage     30.88%   31.70%   +0.81%     
- Complexity      842      885      +43     
============================================
  Files           168      169       +1     
  Lines          6185     6309     +124     
  Branches        679      699      +20     
============================================
+ Hits           1910     2000      +90     
- Misses         4177     4207      +30     
- Partials         98      102       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimmyjames jimmyjames marked this pull request as ready for review August 23, 2024 19:33
@jimmyjames jimmyjames requested review from a team as code owners August 23, 2024 19:33
@jimmyjames jimmyjames added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit 2a9d11a Aug 27, 2024
19 checks passed
@jimmyjames jimmyjames deleted the feat/add-consistency branch August 27, 2024 18:24
@jimmyjames jimmyjames mentioned this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants