Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure executor is shutdown #133

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

jimmyjames
Copy link
Contributor

Description

Calls shutdown on the executor in batchCheck

References

Fixes #132

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@jimmyjames jimmyjames requested a review from a team as a code owner December 18, 2024 19:38
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.72%. Comparing base (5c39f01) to head (972cc80).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #133      +/-   ##
============================================
+ Coverage     31.71%   31.72%   +0.01%     
  Complexity      885      885              
============================================
  Files           169      169              
  Lines          6310     6311       +1     
  Branches        699      699              
============================================
+ Hits           2001     2002       +1     
  Misses         4207     4207              
  Partials        102      102              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimmyjames can we make sure we're doing the same in non-transactional writes?

@jimmyjames
Copy link
Contributor Author

@jimmyjames can we make sure we're doing the same in non-transactional writes?

Yep; there's no other usage of executor in the SDK.

@jimmyjames jimmyjames added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 5bfd685 Dec 18, 2024
19 checks passed
@jimmyjames jimmyjames deleted the fix/fix-executor-not-shutdown branch December 18, 2024 21:15
@jimmyjames jimmyjames mentioned this pull request Dec 18, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executor not shut down in batchCheck
3 participants