Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v0.6.0 #119

Merged
merged 3 commits into from
Jun 28, 2024
Merged

release: v0.6.0 #119

merged 3 commits into from
Jun 28, 2024

Conversation

ewanharris
Copy link
Member

Description

Releasing the OpenTelemetry metrics changes. The first commit is mostly some whitespace changes, license headers, and reordering of things as a consequence of how this change had to be integrated into the generator.

References

Generated from openfga/sdk-generator#383

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

This is mostly some whitespace changes, license headers, and reordering of
things as a consequence of how this change had to be integrated into the
generator
@ewanharris ewanharris requested review from a team as code owners June 28, 2024 13:31
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.48%. Comparing base (1a6bffb) to head (847c456).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   83.48%   83.48%           
=======================================
  Files          19       19           
  Lines        1005     1005           
  Branches      176      176           
=======================================
  Hits          839      839           
  Misses         78       78           
  Partials       88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rhamzeh
rhamzeh previously approved these changes Jun 28, 2024
Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ewanharris do you think we can add the metrics you have documented in the PR to the README? (can be in a follow up PR, does not block release)

Even better if we can have a metrics section in the README that links to docs/OTEL_METRICS.md so as not to clutter the readme.

Please also add a note in both that the metrics are not sent if not configured, and will go to the user's OTEL collector, not to the OpenFGA team, in case the wording scares folks.

CHANGELOG.md Outdated Show resolved Hide resolved
@ewanharris
Copy link
Member Author

@rhamzeh, ah yeah I shoulda thought of that. I'll add it in this PR a it'll then be on the npm docs too

@ewanharris
Copy link
Member Author

@rhamzeh Added some docs in 847c456, pushing the SDK generator changes momentarily.

@ewanharris ewanharris added this pull request to the merge queue Jun 28, 2024
Merged via the queue into main with commit 011b066 Jun 28, 2024
19 checks passed
@ewanharris ewanharris deleted the release/v0.6.0 branch June 28, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants