Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set the consistency parameter correctly in OpenFGAClient #143

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

ewanharris
Copy link
Member

Description

In #129 I somehow overlooked setting the consistency parameter on the underlying API request body, this correctly does that and then adds tests to ensure that this is carried through as expected.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris ewanharris requested a review from a team as a code owner August 23, 2024 15:37
jimmyjames
jimmyjames previously approved these changes Aug 23, 2024
rhamzeh
rhamzeh previously approved these changes Aug 23, 2024
@rhamzeh rhamzeh dismissed stale reviews from jimmyjames and themself via 1370a12 August 23, 2024 18:39
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.13%. Comparing base (15829c3) to head (1370a12).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #143   +/-   ##
=======================================
  Coverage   88.13%   88.13%           
=======================================
  Files          19       19           
  Lines        1003     1003           
  Branches      150      133   -17     
=======================================
  Hits          884      884           
  Misses         82       82           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimmyjames jimmyjames added this pull request to the merge queue Aug 28, 2024
@ewanharris ewanharris merged commit 9b56137 into main Aug 28, 2024
19 checks passed
@ewanharris ewanharris deleted the fix/set-consistency-param branch August 28, 2024 01:47
@jimmyjames jimmyjames mentioned this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants