Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a error return bug in credentials.NewCredentials in the Go SDK. #237

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Fixed a error return bug in credentials.NewCredentials in the Go SDK. #237

merged 2 commits into from
Dec 6, 2023

Conversation

harper
Copy link
Contributor

@harper harper commented Nov 23, 2023

Fixed a error return bug in credentials.NewCredentials in the Go SDK.

Description

The return logic for credentials.NewCredentials in the Go SDK has a bug (it is reversed from what it should be).

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@harper harper requested a review from a team as a code owner November 23, 2023 01:50
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 23, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: harper / name: Harper Trow (aba1fea)
  • ✅ login: adriantam / name: Adrian Tam (8f800b1)

rhamzeh
rhamzeh approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @harper!

@rhamzeh rhamzeh added this pull request to the merge queue Dec 6, 2023
Merged via the queue into openfga:main with commit fa7d3b9 Dec 6, 2023
2 of 7 checks passed
rhamzeh pushed a commit to openfga/go-sdk that referenced this pull request Dec 6, 2023
@harper @rhamzeh
fix: resolve a bug in NewCredentials
3dc6f9f 
Generator PR: openfga/sdk-generator#237
@rhamzeh rhamzeh mentioned this pull request Dec 6, 2023
Merged
4 tasks
github-merge-queue bot pushed a commit to openfga/go-sdk that referenced this pull request Dec 6, 2023
@rhamzeh @harper
fix: resolve a bug in NewCredentials (#60)
81d11d5 
Generator PR: openfga/sdk-generator#237

Co-authored-by: Harper Trow <harper.trow@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

@miparnisari miparnisari miparnisari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harper @rhamzeh @miparnisari @adriantam