feat(go-sdk): support OpenTelemetry metrics #428
Conversation
Bumps the dependencies group with 1 update: [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action). Updates `docker/setup-buildx-action` from 3.6.1 to 3.7.1 - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@988b5a0...c47758b) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
ewanharris
force-pushed
the
chore/backport-go-telemetry
branch
from
b7ba0e6
to
f6c1543
Compare
| | `http.request.method` | string | Yes | HTTP method for the request | | ||
| | `http.request.resend_count` | int | Yes | Number of retries attempted, if any | | ||
| | `http.response.status_code` | int | Yes | Status code of the response (e.g., `200` for success) | | ||
| | `http.server.request.duration` | int | Yes | Time taken by the FGA server to process and evaluate the request, in milliseconds | |
There was a problem hiding this comment.
This should be false by default, same for url.scheme, url.full and http.request.method 🤔
But those are less important - I'm not sure if the config matches the documentation, but it is crucial we do not enable http.server.request.duration as a default attribute b/c it has a very high cardinality
(Side-note: does not need to be in this PR)
There was a problem hiding this comment.
I lifted this from one of the more recent SDKs (I think Python). Shall I just revert to whatever is on main currently in go-sdk?
There was a problem hiding this comment.
Pushed 08996ce to update the file with the table/preamble currently used on main in go-sdk.
| // replace {{gitHost}}/{{gitUserId}}/{{gitRepoId}} v{{packageVersion}} => ../../ |
There was a problem hiding this comment.
Also for a later PR - I think for all examples, we can make local the default
There was a problem hiding this comment.
What dya think about eventually getting rid of things like {{gitHost}}/{{gitUserId}}/{{gitRepoId}} and things like {{appshortname}} in future too now that we have a single SDK publish target? 🥺
Description
Backports the telemetry changes back to the generator repository.
Also brings some actions versions changes and fixes and issue where we weren't correctly passing the consistency down for a batch check down to the individual checks.
References
Review Checklist
main