Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve FigisMap.console for debugging #40

Open
eblondel opened this issue Sep 1, 2016 · 3 comments
Open

Improve FigisMap.console for debugging #40

eblondel opened this issue Sep 1, 2016 · 3 comments
Labels

Comments

@eblondel
Copy link
Member

eblondel commented Sep 1, 2016

FigisMap.console is useful for debugging but because it is called with a custom function, we loose the js code line number where it is invoked within FigisMap. @marcobalestra do you agree that i have a look and possibly improve this?

@marcobalestra
Copy link
Contributor

It's a custom function instead of classic Console.log() because Console.log() is not allowed in IE, then its presence would break js on faulty browsers (IE).
There is also the option to check for existence of Console.log method, and define it if missing in order to avoid errors. I didn't do it because the idea was that FigisMap.js code was populating all and only the FigisMap object.

@eblondel
Copy link
Member Author

eblondel commented Sep 2, 2016

i'm not questioning the function itself, i knew about it was intended to
give logs even when there is no window.console, just wondering if there
would be some way to handle js line involved and not the same js line
pointing to FigisMap.console.. but maybe there is no simple way to do that..

Le 2 sept. 2016 08:52, "Marco Balestra" notifications@github.com a écrit :

It's a custom function instead of classic Console.log() because
Console.log() is not allowed in IE, then its presence would break js on
faulty browsers (IE).
There is also the option to check for existence of Console.log method, and
define it if missing in order to avoid errors. I didn't do it because the
idea was that FigisMap.js code was populating all and only the FigisMap
object.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#40 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABQ1bFNdK7FemXUKhdcWBqf3lx2or5Baks5ql8edgaJpZM4Jyxj-
.

@marcobalestra
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants