Improve housing tax and add metadata to parameters #49
Conversation
fpagnoux
changed the title
fpagnoux
requested review from
Anna-Livia,
MattiSG and
sandcha
and removed request for
Anna-Livia
| @@ -1,4 +1,6 @@ | |||
| # The social_security_contribution is calculated with a marginal scale. Marginal scales are represented with a specific structure. | |||
| description: Social security contribution tax scale | |||
| unit: currency:EUR | |||
There was a problem hiding this comment.
Actually, this is ambiguous: the thresholds are in EUR, but the rates are unit-less! See issue raised by france (in FR, sorry)
fpagnoux
force-pushed
the
parse-metadata
branch
3 times, most recently
from
cd358b6 to
49244d7
Compare
| * Details: | ||
| - Implement housing tax minimal amount | ||
|
|
||
| <!-- --> |
There was a problem hiding this comment.
Why have this separation ?
There was a problem hiding this comment.
Because this PR does two independent things from the user point of view : enriching a formula, and adding metadata to parameters.
(These are not so independent from our developper point of view, as the whole point of adding the minimal amount for the housing tax is to have a yaml file with several parameters that we can use for tests)
| @@ -52,6 +52,9 @@ def formula(household, period, parameters): | |||
| january = period.first_month | |||
| accommodation_size = household('accommodation_size', january) | |||
|
|
|||
| tax_params = parameters(period).taxes.housing_tax | |||
There was a problem hiding this comment.
proposition :
minimal_amount = parameters(period).taxes.housing_tax.minimal_amount
calculated_amount = accommodation_size * parameters(period).taxes.housing_tax.rate
tax_amount = max_(calculated_amount, minimal_amount)There was a problem hiding this comment.
I find the repetition of parameters(period) quite heavy.
I edited the formulas to be a little clearer, let me know if it's enough.
setup.py
Outdated
| @@ -16,7 +16,7 @@ | |||
| url='https://github.com/openfisca/openfisca-country-template', | |||
| include_package_data = True, # Will read MANIFEST.in | |||
| install_requires=[ | |||
| 'OpenFisca-Core >= 23.1, < 24.0', | |||
| 'OpenFisca-Core >= 23.2, < 24.0', | |||
There was a problem hiding this comment.
Il faut mettre à jour la dépendance à Core
Connected to openfisca/openfisca-core#677
Supersedes #48
This PR aims at setting good practice for parameters metadata, pay attention to this part :)