Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define OpenAPI config #58

Merged
merged 3 commits into from
Oct 17, 2018
Merged

Define OpenAPI config #58

merged 3 commits into from
Oct 17, 2018

Conversation

fpagnoux
Copy link
Member

sandcha
sandcha approved these changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@sandcha sandcha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for demo.openfisca.org!
Needs only some flak8 improvement.
Nevertheless, tested locally with on legislation explorer swagger and it works well.

CHANGELOG.md
## 3.4.0

* Introduce `code_postal` variable
* Tax and benefit system evolution.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

openfisca_country_template/__init__.py Outdated
self.open_api_config = {
"variable_example": "disposable_income",
"parameter_example": "taxes.income_tax_rate",
"simulation_example": couple,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@fpagnoux fpagnoux merged commit b46ae77 into master Oct 17, 2018
@fpagnoux fpagnoux deleted the define-openapi-ex branch October 17, 2018 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandcha sandcha sandcha approved these changes

@bonjourmauko bonjourmauko Awaiting requested review from bonjourmauko

@Morendil Morendil Awaiting requested review from Morendil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fpagnoux @sandcha @bonjourmauko