Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make serve-local command to Makefile #85

Merged
merged 3 commits into from
Feb 10, 2020
Merged

Add make serve-local command to Makefile #85

merged 3 commits into from
Feb 10, 2020

Conversation

alexsoble
Copy link

What does this do?

Adds an additional command to the Makefile for quickly serving the API locally:

make serve-local

Why?

  • Makes the Makefile more comprehensive in terms of the commands it offers users.
  • Makes the command to serve the app discoverable via the Makefile.
  • Saves the user from remembering a custom-named command when getting started with a new OpenFisca project.

Notes

  • The Makefile runs the serve command without any arguments as a form of quickstart; a user would need to run the full openfisca serve command if they want to send it command line arguments.
  • Named the command serve-local under the assumption that users will want different config when serving in production.

Minor change. These changes:

  • Change non-functional parts of this repository (for instance editing the README).

+ Save the user a step in getting started; make serving the app locally discoverable via the Makefile
@alexsoble
Copy link
Author

☝️ A short note on motivation — as I've spun up a few prototype OpenFisca projects recently, I've found a make serve-local shortcut useful for getting started faster.

Opening this PR in case other newer folks would find this useful too!

@bonjourmauko bonjourmauko merged commit 019e654 into openfisca:master Feb 10, 2020
@bonjourmauko
Copy link
Member

Thanks !

@bonjourmauko bonjourmauko self-assigned this May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants