Deploy documentation #1211
Merged
Deploy documentation #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ndpnt
approved these changes
May 22, 2024
|
Proven to work: this core deploy triggered this doc deploy. |
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical changes
Proof that the deployment is triggered can be found on the Doc Actions log.
Details of implementation and difficulties can be found on openfisca/openfisca-doc#308 (comment).
I suggest to wait until openfisca/openfisca-doc#309 is merged to proceed with merging this PR, as it would be the ideal moment to change the
reftomainrather than having an additional patch published later. The review is still relevant to have now thought, considering that the logic itself will not change.If this PR is merged:
CIRCLECI_OPENFISCADOC_TOKENsecret should be erasedCIRCLECI_V1_OPENFISCADOC_TOKENsecret should be erased