Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix doc & type definitions in the entities module #1220

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

bonjourmauko
Copy link
Member

@bonjourmauko bonjourmauko commented Sep 16, 2024

Fixes #1231
Depends on #1219
Depended upon by #1146

Technical changes

  • Fix doc & type definitions in the entities module

@bonjourmauko bonjourmauko added level:starter Suited for beginners and new contributors kind:refactor Refactoring and code cleanup labels Sep 16, 2024
@bonjourmauko bonjourmauko requested review from a team September 16, 2024 23:17
@bonjourmauko bonjourmauko self-assigned this Sep 16, 2024
@coveralls
Copy link

coveralls commented Sep 16, 2024

Coverage Status

coverage: 74.736% (+0.06%) from 74.675%
when pulling 7b37709 on fix-mypy-checks-ent
into 5aaca86 on fix-mypy-checks.

@bonjourmauko
Copy link
Member Author

Thanks @benjello ! If it is not much to ask, this one depends on #1219.

@bonjourmauko bonjourmauko changed the title Fix doc & type definitions in the entities module [3/17] Fix doc & type definitions in the entities module Sep 17, 2024
Base automatically changed from fix-mypy-checks to master September 18, 2024 11:00
@bonjourmauko bonjourmauko merged commit 00fe69a into master Sep 18, 2024
22 checks passed
@bonjourmauko bonjourmauko deleted the fix-mypy-checks-ent branch September 18, 2024 11:09
@bonjourmauko bonjourmauko mentioned this pull request Sep 18, 2024
17 tasks
This was referenced Sep 25, 2024
@bonjourmauko bonjourmauko changed the title [3/17] Fix doc & type definitions in the entities module docs: fix doc & type definitions in the entities module Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:refactor Refactoring and code cleanup level:starter Suited for beginners and new contributors
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add typing to entities
3 participants