Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add matrix & fix conda #1257

Merged
merged 15 commits into from
Oct 4, 2024
Merged

ci: add matrix & fix conda #1257

merged 15 commits into from
Oct 4, 2024

Conversation

bonjourmauko
Copy link
Member

@bonjourmauko bonjourmauko commented Oct 2, 2024 •
edited
Loading

Fixes #1173
Relates to openfisca/country-template#124
Relates to openfisca/extension-template#43

Technical changes

  • Fix conda test and publish
  • Add matrix testing to CI
    • Now it tests lower and upper bounds of python and numpy versions

@bonjourmauko bonjourmauko force-pushed the fix/failing-test branch 24 times, most recently from df382dd to 7122ed2 Compare October 2, 2024 21:00
@bonjourmauko bonjourmauko requested review from sandcha and a team October 3, 2024 16:03
@bonjourmauko bonjourmauko force-pushed the fix/failing-test branch 14 times, most recently from a8da3a5 to 36f095a Compare October 3, 2024 22:53
@bonjourmauko bonjourmauko mentioned this pull request Oct 3, 2024
Closed
@bonjourmauko bonjourmauko changed the title ci: add matrix ci: add matrix & fix conda Oct 3, 2024
benoit-cty
benoit-cty approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@benoit-cty benoit-cty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's better now !

@bonjourmauko
Copy link
Member Author

Thanks, it's better now !

We still have some issues to tacke in other PRs:

  • Should we use a common lock file, like with poetry, to make builds deterministic in PyPi and Conda
  • The two-staged build process (core -> templates -> core-dev)
  • The publishing of templates

@bonjourmauko bonjourmauko merged commit bbf342f into master Oct 4, 2024
29 checks passed
@bonjourmauko bonjourmauko deleted the fix/failing-test branch October 4, 2024 14:08
@bonjourmauko bonjourmauko mentioned this pull request Oct 4, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoit-cty benoit-cty benoit-cty approved these changes

@sandcha sandcha Awaiting requested review from sandcha

Assignees

@bonjourmauko bonjourmauko

Labels
kind:ci Continuous ops, integration & deployment
Projects
OpenFisca International
Status: Shipped
Milestone
Improved releases
Development

Successfully merging this pull request may close these issues.
2 participants
@bonjourmauko @benoit-cty