Document calc(..., right) arg for parameter scales
#266
Conversation
There was a problem hiding this comment.
I understand that because of #267, many more changes than expected were introduced in this PR. In particular, I understand that only lines 144 and 145 implement the described change. I thus offer to replace this PR with another one until #267 is implemented, to speed up integration of this good contribution 🙂
| - `tax_on_salaries` , `tax_on_salary.public_sector` , `universal_income` are **nodes**; | ||
| - `tax_on_salaries.tax_scale` , `tax_on_salary.public_sector.rate` , `universal_income.minimum_age` , `universal_income.amount` are **parameters** (or scales). |
There was a problem hiding this comment.
I'm not sure about these added spaces before commas. I understand that even though those are code items, they should be read as part of a sentence. Could you please roll this back? 🙂
| > | ||
|
|
||
| ```py |
There was a problem hiding this comment.
This seems inappropriate as it shifts from “quoted code” to “coded quote”.
|
@MaxGhenis I'll let you check that #268 indeed contains the entirety of the changes you intended, and close this PR if it is the case 🙂 |
|
Thanks @MattiSG - yes, everything except those lines was introduced by my editor. |
|
Thank you for your understanding and sorry for this being harder than it should! |
No description provided.