Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update to openfisca-core v43 #2357

Merged
merged 11 commits into from
Oct 18, 2024
Merged

Conversation

bonjourmauko
Copy link
Member

@bonjourmauko bonjourmauko commented Sep 26, 2024

Depends on openfisca/openfisca-core#1223

  • Changement mineur.
  • Détails :
    • MàJ d'OpenFisca-Core

Ces changements :

  • Modifient des éléments non fonctionnels de ce dépôt (par exemple modification du README).

Quelques conseils à prendre en compte :

@bonjourmauko bonjourmauko added the kind:dependencies Pull requests that update a dependency file label Sep 26, 2024
@bonjourmauko bonjourmauko self-assigned this Sep 26, 2024
@bonjourmauko
Copy link
Member Author

@benjello @benoit-cty As with the other PR, this is just to test that the changes in core do not break the lib. The conda build will always fail, because we're installing from a URL. Once changes to core are accepted and merged, this PR becomes obsolete, and it has to go back to the regular PyPi -now published- package with the required version. Only then the Conda build will work. If you wait for the Conda build to accept changes in core, it won't ever happen.

@bonjourmauko bonjourmauko changed the title chore: update to openfisca-core 42.0.0 build: update to openfisca-core 42.0.0 Sep 30, 2024
@bonjourmauko bonjourmauko force-pushed the chore/update-core-42.0.0 branch 2 times, most recently from eb4fc5b to 10e2a82 Compare September 30, 2024 21:47
@bonjourmauko bonjourmauko force-pushed the chore/update-core-42.0.0 branch from 10e2a82 to f72aca3 Compare October 10, 2024 16:54
@bonjourmauko bonjourmauko changed the title build: update to openfisca-core 42.0.0 build: update to openfisca-core 43 Oct 14, 2024
@bonjourmauko bonjourmauko changed the base branch from master to update-openfisca-core-v42 October 14, 2024 13:50
@bonjourmauko bonjourmauko changed the title build: update to openfisca-core 43 build: update to openfisca-core v43 Oct 14, 2024
@bonjourmauko bonjourmauko force-pushed the chore/update-core-42.0.0 branch from f72aca3 to 51ba71d Compare October 14, 2024 13:53
@benjello
Copy link
Member

@bonjourmauko : je crois que je sais d'où vient le problème. Je vais pousser une correction.

@bonjourmauko
Copy link
Member Author

@benjello I wonder if it is a test related to the Python version / Numpy version ? I've been working in development with py3.12 and np2.0.2 in core, but with py3.9 and np1.26 in France.

@bonjourmauko bonjourmauko requested a review from Shamzic October 14, 2024 15:07
@bonjourmauko
Copy link
Member Author

For the Conda build..., it fails because now core is being correctly published to conda. You need to fix the recipe.

@bonjourmauko bonjourmauko force-pushed the chore/update-core-42.0.0 branch 6 times, most recently from 020bfdb to 2ce87fa Compare October 15, 2024 09:45
@bonjourmauko bonjourmauko force-pushed the chore/update-core-42.0.0 branch 9 times, most recently from 756912a to 2132407 Compare October 15, 2024 11:12
@bonjourmauko
Copy link
Member Author

Voilà ! :)

@bonjourmauko bonjourmauko changed the base branch from update-openfisca-core-v42 to master October 16, 2024 15:58
@bonjourmauko bonjourmauko force-pushed the chore/update-core-42.0.0 branch from 2132407 to 38ae160 Compare October 16, 2024 16:04
@bonjourmauko
Copy link
Member Author

LGTM ?

@benjello
Copy link
Member

@sylvainipp @clallemand @benoit-cty your call !

Copy link
Contributor

@benoit-cty benoit-cty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
All the code looks good to me, but seems to do not work:

git switch chore/update-core-42.0.0
python3 -m venv .venv
source .venv/bin/activate
make install

Return:

The conflict is caused by:
    openfisca-france[dev] 169.0.0 depends on pytest<8.0 and >=7.2.2; extra == "dev"
    openfisca-core 43.2.0 depends on pytest<9.0 and >=8.3.3
    openfisca-france[dev] 169.0.0 depends on pytest<8.0 and >=7.2.2; extra == "dev"
    openfisca-core 43.1.2 depends on pytest<9.0 and >=8.3.3
    openfisca-france[dev] 169.0.0 depends on pytest<8.0 and >=7.2.2; extra == "dev"
    openfisca-core 43.1.1 depends on pytest<9.0 and >=8.3.3
    openfisca-france[dev] 169.0.0 depends on pytest<8.0 and >=7.2.2; extra == "dev"
    openfisca-core 43.1.0 depends on pytest<9.0 and >=8.3.3
    openfisca-france[dev] 169.0.0 depends on pytest<8.0 and >=7.2.2; extra == "dev"
    openfisca-core 43.0.0 depends on pytest<9.0 and >=8.3.3
python -V
=> Python 3.10.5

And the CI fail : https://github.com/openfisca/openfisca-france/actions/runs/11369496601/job/31670917208?pr=2357

for make check-style that works locally.

@bonjourmauko
Copy link
Member Author

Yep, the thing is pytest is a production requirement of core. Fixing it.

Copy link
Contributor

@benoit-cty benoit-cty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it works 👍

@bonjourmauko bonjourmauko force-pushed the chore/update-core-42.0.0 branch from 616cc7f to 901534c Compare October 18, 2024 12:24
@bonjourmauko bonjourmauko merged commit f1af948 into master Oct 18, 2024
38 checks passed
@bonjourmauko bonjourmauko deleted the chore/update-core-42.0.0 branch October 18, 2024 12:56
@Shamzic
Copy link
Contributor

Shamzic commented Oct 18, 2024

Thanks everyone 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants