-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update to openfisca-core v43 #2357
Conversation
@benjello @benoit-cty As with the other PR, this is just to test that the changes in core do not break the lib. The conda build will always fail, because we're installing from a URL. Once changes to core are accepted and merged, this PR becomes obsolete, and it has to go back to the regular PyPi -now published- package with the required version. Only then the Conda build will work. If you wait for the Conda build to accept changes in core, it won't ever happen. |
eb4fc5b
to
10e2a82
Compare
10e2a82
to
f72aca3
Compare
f72aca3
to
51ba71d
Compare
@bonjourmauko : je crois que je sais d'où vient le problème. Je vais pousser une correction. |
@benjello I wonder if it is a test related to the Python version / Numpy version ? I've been working in development with py3.12 and np2.0.2 in core, but with py3.9 and np1.26 in France. |
For the Conda build..., it fails because now core is being correctly published to conda. You need to fix the recipe. |
020bfdb
to
2ce87fa
Compare
756912a
to
2132407
Compare
Voilà ! :) |
2132407
to
38ae160
Compare
LGTM ? |
@sylvainipp @clallemand @benoit-cty your call ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
All the code looks good to me, but seems to do not work:
git switch chore/update-core-42.0.0
python3 -m venv .venv
source .venv/bin/activate
make install
Return:
The conflict is caused by:
openfisca-france[dev] 169.0.0 depends on pytest<8.0 and >=7.2.2; extra == "dev"
openfisca-core 43.2.0 depends on pytest<9.0 and >=8.3.3
openfisca-france[dev] 169.0.0 depends on pytest<8.0 and >=7.2.2; extra == "dev"
openfisca-core 43.1.2 depends on pytest<9.0 and >=8.3.3
openfisca-france[dev] 169.0.0 depends on pytest<8.0 and >=7.2.2; extra == "dev"
openfisca-core 43.1.1 depends on pytest<9.0 and >=8.3.3
openfisca-france[dev] 169.0.0 depends on pytest<8.0 and >=7.2.2; extra == "dev"
openfisca-core 43.1.0 depends on pytest<9.0 and >=8.3.3
openfisca-france[dev] 169.0.0 depends on pytest<8.0 and >=7.2.2; extra == "dev"
openfisca-core 43.0.0 depends on pytest<9.0 and >=8.3.3
python -V
=> Python 3.10.5
And the CI fail : https://github.com/openfisca/openfisca-france/actions/runs/11369496601/job/31670917208?pr=2357
for make check-style
that works locally.
Yep, the thing is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it works 👍
616cc7f
to
901534c
Compare
Thanks everyone 🙏 |
Depends on openfisca/openfisca-core#1223
Ces changements :
Quelques conseils à prendre en compte :
Documentez votre contribution avec des références législatives.Mettez à jour ou ajoutez des tests correspondant à votre contribution.setup.py
.CHANGELOG.md
.