Deprecate unused variables #671
Conversation
Deprecate tva_ent
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| setup( | |||
| name = 'OpenFisca-France', | |||
| version = '12.0.4', | |||
| version = '12.0.5', | |||
There was a problem hiding this comment.
Isn't it a major change, to remove 2 variables?
@MattiSG any advice?
There was a problem hiding this comment.
Ce sont des reliquats qui ont été remplacés par d'autres variables sans avoir été supprimées.
C'est plus du nettoyage qu'autre chose.
There was a problem hiding this comment.
Dépréciation = changement mineur à minima.
Suppression = changement majeur.
Cf. https://speakerdeck.com/mattisg/git-session-2-strategies?slide=81
|
Pour bien comprendre : |
| ## 12.0.5 | ||
|
|
||
| * Minor version change because deprecating unused variables | ||
| * Deprecate nbsala |
There was a problem hiding this comment.
Jusqu'à maintenant on utilise plutôt deprecate.
There was a problem hiding this comment.
|
Pour moi c'est un changement mineur.
|
Il n'y a pas à avoir d'évaluation personnelle : le schéma de versionnement est totalement normalisé et documenté sur http://semver.org :) S'il y a une suppression, cela change l'API publique de manière non rétro-compatible, et cela occasionne donc un changement du numéro de version majeur. |
|
|
||
| * Deprecate `nbsala` | ||
| * Deprecate `tva_ent` | ||
| * Low impact changes since deprecating unused variables |
There was a problem hiding this comment.
When I read this, I understand that you deprecated two variables and did other low impact changes.
I'm not even sure the third point is necessary at all. If you think it is important, please make sure to explain that is it not a change, but additional info about the two first lines.
For instance you can remove the bullet, and instead having a full sentence "These changes are low impact since the two deprecated variables were not used"
|
@fpagnoux is this GTM for you now ? |
No description provided.