Replace warning by assertion for no weights if weighted is True for compute_aggregate #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjello
reviewed
Apr 17, 2024
bfabre01
force-pushed
the
assertion-no-weithed-compute-aggregate
branch
2 times, most recently
from
9da6632 to
4d47b6b
Compare
added 2 commits
April 23, 2024 14:12
|
@benjello : c'est bon, tous les tests passent maintenant. |
Lolajossipp
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims at solving #287 : for
compute_aggregate, replace the warning by an assert whenweighted = True(the default) and no weight is defined for the variable. Before, a warning was displayed and the aggregate was computed using uniform weights.