Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS status bar dimming. #1880

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

MAJigsaw77
Copy link
Contributor

When using SDL_WINDOW_FULLSCREEN_DESKTOP on iOS, the status bar dimming was not functioning correctly.

Before:

IMG_0010

After:

IMG_0009

(Sorry for the color difference in the images, but the status bar in the second image is clearly dimmed compared to the first.)

This change resolves the issue and restores the expected dimming behavior.

@player-03
Copy link
Contributor

That's a lot of conditionals for such a small thing. Are we sure there isn't a simpler way to handle it?

@MAJigsaw77
Copy link
Contributor Author

That's a lot of conditionals for such a small thing. Are we sure there isn't a simpler way to handle it?

This is the easiest way i could make it work, if you can make it be better, feel free to do so!

@player-03
Copy link
Contributor

I've taken a stab at simplifying. Got down to only one #if, which will make future changes easier if they prove necessary.

@MAJigsaw77
Copy link
Contributor Author

MAJigsaw77 commented Dec 29, 2024

Tbh, I'm actually wondering if android needs the SDL_WINDOW_FULLSCREEN_DESKTOP , it isn't doing anything in android as well.

@player-03
Copy link
Contributor

Fair question.

@MAJigsaw77
Copy link
Contributor Author

Fair question.

After checking SDL2's source, there's nothing pointing that android uses SDL_WINDOW_FULLSCREEN_DESKTOP in any way, so ig it is fine to just remove it from android as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants