Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Add kafka required acks env #32

Merged
merged 1 commit into from
Aug 8, 2021
Merged

Add kafka required acks env #32

merged 1 commit into from
Aug 8, 2021

Conversation

zhouzhuojie
Copy link
Contributor

Related #21

Adding an option to config the required acks for kafka.

@codecov-commenter
Copy link

Codecov Report

Merging #32 (fefb8de) into main (8698373) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   81.55%   81.55%           
=======================================
  Files          27       27           
  Lines        2174     2174           
=======================================
  Hits         1773     1773           
  Misses        314      314           
  Partials       87       87           
Impacted Files Coverage Δ
pkg/handler/data_recorder_kafka.go 72.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ef694b...fefb8de. Read the comment docs.

@zhouzhuojie zhouzhuojie merged commit b67bf79 into main Aug 8, 2021
@zhouzhuojie zhouzhuojie deleted the add-kafka-required-acks branch August 8, 2021 21:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants