Merge pull request #271 from checkr/zz/tune-search-feature

Use lower case and computed for search terms
openflagr · Jun 20, 2019 · 7979b1d · 7979b1d
2 parents 6dd6c33 + f704f71
commit 7979b1d
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/browser/flagr-ui/src/components/Flags.vue b/browser/flagr-ui/src/components/Flags.vue
@@ -114,7 +114,6 @@ export default {
     return {
       loaded: false,
       flags: [],
-      filteredFlags: [],
       searchTerm: '',
       newFlag: {
         description: ''
@@ -128,21 +127,18 @@ export default {
         this.loaded = true
         flags.reverse()
         this.flags = flags
-        this.filteredFlags = [...flags];
       }, handleErr.bind(this))
   },
-  watch: {
-    searchTerm: function() {
+  computed: {
+    filteredFlags: function() {
       if (this.searchTerm) {
-        this.filteredFlags = this.flags.filter(
+        return this.flags.filter(
           ({ id, description}) =>
             id.toString().includes(this.searchTerm) ||
-            description.includes(this.searchTerm)
+            description.toLowerCase().includes(this.searchTerm.toLowerCase())
         )
       }
-      else {
-        this.filteredFlags = [...this.flags]
-      }
+      return this.flags
     }
   },
   methods: {