Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use multi-stage build for dockerfile #107

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Use multi-stage build for dockerfile #107

merged 1 commit into from
Apr 4, 2018

Conversation

zhouzhuojie
Copy link
Collaborator

Use multi-stage build. Requires docker 17.09+.

The image size is down to 40mb.

@zhouzhuojie zhouzhuojie requested a review from a team April 4, 2018 18:07
ziru
ziru approved these changes Apr 4, 2018
View reviewed changes
Copy link

@ziru ziru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup. avoid including build dependencies in the docker image. we only need runtime dependencies in the final image.

@zhouzhuojie zhouzhuojie merged commit 459f44c into master Apr 4, 2018
@zhouzhuojie zhouzhuojie deleted the zz/change-docker-base branch April 4, 2018 18:55
@zhouzhuojie zhouzhuojie mentioned this pull request Apr 4, 2018
Closed
@sks sks mentioned this pull request Nov 3, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziru ziru ziru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhouzhuojie @ziru