Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InsecureVerifySSL config #137

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Conversation

zhouzhuojie
Copy link
Collaborator

From the definition of InsecureSkipVerify:

// InsecureSkipVerify controls whether a client verifies the     
// server's certificate chain and host name.                     
// If InsecureSkipVerify is true, TLS accepts any certificate    
// presented by the server and any host name in that certificate.
// In this mode, TLS is susceptible to man-in-the-middle attacks.
// This should be used only for testing.                         

@zhouzhuojie zhouzhuojie requested a review from ziru June 28, 2018 17:58
@zhouzhuojie zhouzhuojie merged commit 4e7ce45 into master Jun 28, 2018
@zhouzhuojie zhouzhuojie deleted the zz/fix-insecure-verify-tls branch June 28, 2018 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants