-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed input text to json-editor in flag variant form #258
Changed input text to json-editor in flag variant form #258
Conversation
Codecov Report
@@ Coverage Diff @@
## master #258 +/- ##
=====================================
Coverage 82% 82%
=====================================
Files 26 26
Lines 1528 1528
=====================================
Hits 1253 1253
Misses 207 207
Partials 68 68 Continue to review full report at Codecov.
|
@zhouzhuojie @yosyad Together with #259 we are basically allowing for very good user experience when editing more complex JSON attachment data. Looking forward to seeing this merged. |
@zhouzhuojie I finished the design. It looks like the following image: Please let me know if there is something more than I can do. |
</el-col> | ||
</el-row> | ||
<el-collapse class="flex-row"> | ||
<el-collapse-item title="Variant attachment" class="variant-attachment-collapsable-title"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious, if variant.attachment is not empty (null or {}), can we automatically show the attachment? Just want to highlight the visibility of non-empty attachment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhouzhuojie It seems like element-ui
does not support manually setting the active
flag, so I think that this is not possible to use out of the box capabilities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 thanks! @yosyad
🎉 Waiting for the official docker hub image :) |
Description
In order to edit easily the variant attachment, I replaced the existing input to the same json editor that used in the evaluator on the same page.
Motivation and Context
I was trying to use flagr with a variant that has more than one key and found myself struggling with the input area. The existing input area was designed for using simple texts in forms, such as name or email, but not JSON.
In order to edit JSON, with syntax highlighting and auto-correct, out of the box, I found my self use the same component that was used on the same page.
How Has This Been Tested?
Tested locally, manually.
Types of changes
Checklist: