Refactor gha workflows

.github/workflows/changelog.yml → .github/workflows/cd_changelog.yml

@@ -1,4 +1,4 @@
-name: changelog
+name: cd_changelog
 
 on:
   release:

.github/workflows/publish_docker.yml → .github/workflows/cd_docker.yml

@@ -1,4 +1,4 @@
-name: publish_docker
+name: cd_docker
 
 on:
   release:
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2
-    - run: echo "RELEASE_VERSION=$(echo ${GITHUB_REF:10})" >> $GITHUB_ENV
+    - run: echo "RELEASE_VERSION=${GITHUB_REF:10}" >> "$GITHUB_ENV"
     - name: Publish Docker SemVer Tag
       uses: elgohr/Publish-Docker-Github-Action@3.04
       with:

.github/workflows/deploy_demo_heroku.yml → .github/workflows/cd_heroku.yml

@@ -1,4 +1,7 @@
-name: deploy_demo_heroku
+# ******** NOTE ********
+# Deploy the https://try-openflagr.herokuapp.com demo service on main branch merges
+#
+name: cd_heroku
 
 on:
   push:
@@ -8,6 +11,7 @@ on:
 
 jobs:
   build:
+    environment: heroku
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2

.github/workflows/ci.yml

@@ -15,7 +15,7 @@ jobs:
           go-version: 1.19
       - name: Check out source code
         uses: actions/checkout@v1
-      - run: echo "$(go env GOPATH)/bin" >> $GITHUB_PATH
+      - run: echo "$(go env GOPATH)/bin" >> "$GITHUB_PATH"
       - run: make deps
       - run: make verify_swagger_nochange
       - run: make ci
@@ -40,3 +40,14 @@ jobs:
       - run: cd integration_tests && make down
       - run: cd integration_tests && make up
       - run: cd integration_tests && make test
+  actionlint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: Download actionlint
+        id: get_actionlint
+        run: bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash)
+        shell: bash
+      - name: Check workflow files
+        run: ${{ steps.get_actionlint.outputs.executable }} -color
+        shell: bash

.github/workflows/codeql-analysis.yml → .github/workflows/ci_codeql.yml

@@ -9,7 +9,7 @@
 # the `language` matrix defined below to confirm you have the correct set of
 # supported CodeQL languages.
 #
-name: "CodeQL"
+name: ci_codeql
 
 on:
   push:
@@ -48,11 +48,11 @@ jobs:
         # If you wish to specify custom queries, you can do so here or in a config file.
         # By default, queries listed here will override any specified in a config file.
         # Prefix the list here with "+" to use these queries and those in the config file.
-        
+
         # Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
         # queries: security-extended,security-and-quality
 
-        
+
     # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
     # If this step fails, then you should remove it and run the build manually (see below)
     - name: Autobuild
@@ -61,7 +61,7 @@ jobs:
     # ℹ️ Command-line programs to run using the OS shell.
     # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
 
-    #   If the Autobuild fails above, remove it and uncomment the following three lines. 
+    #   If the Autobuild fails above, remove it and uncomment the following three lines.
     #   modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance.
 
     # - run: |