refactor(Product input row): new PriceCategoryChip to display the category_tag localized #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Following changes in #1291 we can now display the price's product data as readonly.
But there was an issue when displaying the
category_taglabel (for a raw product price), we were missing a translation mecanism (similar to the existingPriceOrigins&PriceLabelscomponents).Fixes this by creating a new
PriceCategoryChipScreenshot
Extra notes
Todo in the future:
PriceOrigins&PriceLabelsto avoid having the v-if at the topPriceOrigins&PriceLabelsto add "Chip" in their name