Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new Product.product_quantity_unit field #194

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Feb 7, 2024

What

Thanks to openfoodfacts/openfoodfacts-server#9608 there is now a new field in OFF : product_quantity_unit (we already stored product_quantity)

  • added the field to the Product model
  • updated the sync with OFF
  • added the field to the schema (will be returned by the API)

@raphodn raphodn linked an issue Feb 7, 2024 that may be closed by this pull request
@raphodn raphodn requested a review from raphael0202 February 7, 2024 11:13
Copy link
Contributor

@raphael0202 raphael0202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raphodn raphodn merged commit aa353bf into main Feb 8, 2024
5 checks passed
@raphodn raphodn deleted the raphodn/product-quantity-unit-field branch February 8, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify the product quantity unit (g or mL)
2 participants