refactor(sync): log extra info #288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
force-pushed
the
raphodn/sync-additional-logs
branch
from
89b8d47
to
c6cf0c7
Compare
raphodn
commented
May 21, 2024
| dataset = ProductDataset( | ||
| flavor=flavor, | ||
| dataset_type=DatasetType.jsonl, | ||
| force_download=True, | ||
| download_newer=True, | ||
| ) | ||
| logger.info(f"Dataset size: {dataset.count()}") |
There was a problem hiding this comment.
the .count() command seems to take a looong time for the OFF dataset 🤔
raphodn
force-pushed
the
main
branch
4 times, most recently
from
86b4729
to
294261f
Compare
|
Not needed anymore following #366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add some logging during the sync task, to better understand how many products are available in the dumps