Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to JUnit 5 #3137

Closed
Tracked by #4181
VaiTon opened this issue May 18, 2020 · 6 comments · Fixed by #4442
Closed
Tracked by #4181

Upgrade to JUnit 5 #3137

VaiTon opened this issue May 18, 2020 · 6 comments · Fixed by #4442
Labels
dependencies Pull requests that update a dependency file java8 tests

Comments

@VaiTon
Copy link
Member

VaiTon commented May 18, 2020 •
edited
Loading

And upgrade min java required to v8
@VaiTon VaiTon added tests dependencies Pull requests that update a dependency file labels May 18, 2020
@VaiTon
Copy link
Member Author

VaiTon commented May 18, 2020

Apparently as of Android plugin 3.0.0 Java 8 is supported.

@teolemon
Copy link
Member

Does that include bumping the min version of Android ?

@VaiTon
Copy link
Member Author

VaiTon commented May 19, 2020

Does that include bumping the min version of Android ?

No, android studio takes care of the "desugaring".

@teolemon
Copy link
Member

👍
I think we should at least do one more release with all fixes before we could consider version bumps. And also, it needs to bring something to the table feature wise, IMO.

@teolemon teolemon added the java8 label May 8, 2021
@teolemon
Copy link
Member

teolemon commented May 8, 2021

@VaiTon did we upgrade to Java8 ?

@VaiTon
Copy link
Member Author

VaiTon commented May 16, 2021

@VaiTon did we upgrade to Java8 ?

Yup, I think we did it with the last AGP update.

@teolemon teolemon mentioned this issue Aug 25, 2021
Open
7 tasks
@R4md4c R4md4c mentioned this issue Jan 23, 2022
Merged
VaiTon pushed a commit that referenced this issue Jan 25, 2022
@R4md4c
JUnit 5 migration (#4442)
a20c399 
* Upgrade to JUnit 5

Fixes #3137

* clean up build.gradle.kts file

* Migrate ProductsAPITest to JUnit 5

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file java8 tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JUnit 5 migration
2 participants
@teolemon @VaiTon