feat: API V3 now supported for "get product" #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New files: * `LocalizedTag.dart`: Tag with localizations (in English and an additional language). * `LocalizedTag.g.dart`: generated * `ProductResultV3.dart`: API V3 answer from a call to /api/v3/product/$barcode. * `ProductResultV3.g.dart`: generated * `ProductResultField.dart`: Field part of an API V3 answer. * `ProductResultField.g.dart`: generated * `ProductResultFieldAnswer.dart`: API V3 answer for one field. * `ProductResultFieldAnswer.g.dart`: generated Delete file: * `api_getProductRaw_test.dart` Impacted files: * `api_addProductImage_test.dart`: upgraded to `getProductV3` * `api_getProduct_test.dart`: upgraded to `getProductV3` * `api_matchedProductV1_test.dart`: upgraded to `getProductV3` * `api_ocrIngredients_test.dart`: upgraded to `getProductV3` * `api_saveProduct_test.dart`: upgraded to `getProductV3` * `json_product_generation_test.dart`: upgraded to `getProductV3` * `main.dart`: upgraded to `getProductV3` * `openfoodfacts.dart`: deprecated methods `getProductRaw` and `getProduct` in favor of new method `getProductV3 * `product_from_json_test.dart`: upgraded to `getProductV3` * `ProductQueryConfigurations.dart`: added `ProductQueryVersion.v3` and its specific call settings * `ProductResult.dart`: deprecated, in favor of `ProductResultV3`
M123-dev
approved these changes
Dec 2, 2022
|
Thank you very much @M123-dev for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New files:
LocalizedTag.dart: Tag with localizations (in English and an additional language).LocalizedTag.g.dart: generatedProductResultV3.dart: API V3 answer from a call to /api/v3/product/$barcode.ProductResultV3.g.dart: generatedProductResultField.dart: Field part of an API V3 answer.ProductResultField.g.dart: generatedProductResultFieldAnswer.dart: API V3 answer for one field.ProductResultFieldAnswer.g.dart: generatedDelete file:
api_getProductRaw_test.dartImpacted files:
api_addProductImage_test.dart: upgraded togetProductV3api_getProduct_test.dart: upgraded togetProductV3api_matchedProductV1_test.dart: upgraded togetProductV3api_ocrIngredients_test.dart: upgraded togetProductV3api_saveProduct_test.dart: upgraded togetProductV3json_product_generation_test.dart: upgraded togetProductV3main.dart: upgraded togetProductV3openfoodfacts.dart: deprecated methodsgetProductRawandgetProductin favor of new methodgetProductV3product_from_json_test.dart: upgraded togetProductV3ProductQueryConfigurations.dart: addedProductQueryVersion.v3and its specific call settingsProductResult.dart: deprecated, in favor ofProductResultV3What
packagingsfield with its API V3 specific features.packagingswill be dealt with in a next PR.Part of