feat: add USER_AGENT constant and include it in API request headers #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bengeois just a thought, can we add the package.json version somehow? |
|
@VaiTon I was hesitating, it can be a good thing to add it as well, yes. I've made an update with a proposal to include it |
bengeois
force-pushed
the
ft/user-agent
branch
from
52607a6
to
3c10200
Compare
|
VaiTon
approved these changes
Nov 6, 2024
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This pull request introduces the
USER_AGENTconstant and integrates it all API client classes to standardize the user agent used in HTTP requests.Note that there may be a change in the future to request a mandatory user-agent with this issue #310