feat: add data quality warning for serving size without digit (#8057)

openfoodfacts · Feb 6, 2023 · aa9404d · aa9404d
1 parent d71943f
commit aa9404d
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/lib/ProductOpener/DataQualityFood.pm b/lib/ProductOpener/DataQualityFood.pm
@@ -659,6 +659,13 @@ sub check_nutrition_data ($product_ref) {
 					"en:nutrition-data-prepared-without-category-dried-products-to-be-rehydrated";
 			}
 		}
+
+		if (    (defined $product_ref->{serving_size})
+			and ($product_ref->{serving_size} ne "")
+			and ($product_ref->{serving_size} !~ /\d/))
+		{
+			push @{$product_ref->{data_quality_errors_tags}}, "en:serving-size-is-missing-digits";
+		}
 		if (    $nutrition_data
 			and (defined $product_ref->{nutrition_data_per})
 			and ($product_ref->{nutrition_data_per} eq 'serving'))

diff --git a/tests/unit/dataqualityfood.t b/tests/unit/dataqualityfood.t
@@ -486,4 +486,20 @@ check_quality_and_test_product_has_quality_tag(
 	'nutriment should have positive value (except nutrition-score)', 0
 );
 
+# serving size should contains digits
+$product_ref = {serving_size => "serving_size"};
+ProductOpener::DataQuality::check_quality($product_ref);
+check_quality_and_test_product_has_quality_tag(
+	$product_ref,
+	'en:serving-size-is-missing-digits',
+	'serving size should contains digits', 1
+);
+$product_ref = {serving_size => "120g"};
+ProductOpener::DataQuality::check_quality($product_ref);
+check_quality_and_test_product_has_quality_tag(
+	$product_ref,
+	'en:serving-size-is-missing-digits',
+	'serving size should contains digits', 0
+);
+
 done_testing();