fix: make facets URLS /nova-group/unknown work #10498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4nt0ineB
added
🚦Nutri-Score
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10498 +/- ##
==========================================
- Coverage 49.54% 49.33% -0.22%
==========================================
Files 67 76 +9
Lines 20650 21706 +1056
Branches 4980 5209 +229
==========================================
+ Hits 10231 10708 +477
- Misses 9131 9683 +552
- Partials 1288 1315 +27 ☔ View full report in Codecov by Sentry. |
lib/ProductOpener/Display.pm
Outdated
| @@ -4819,6 +4819,8 @@ sub add_params_to_query ($request_ref, $query_ref) { | |||
| if $log->is_debug(); | |||
|
|
|||
| # if the value is "unknown", we need to add a condition on the field being empty | |||
|
|
|||
| my @tagtype_allowing_unknown_as_value = qw(nutrition_grades nova_groups ecoscore); | |||
There was a problem hiding this comment.
Can you add pnns_groups_1, pnns_groups_2 and food_groups?
lib/ProductOpener/Display.pm
Outdated
| @@ -4831,7 +4833,7 @@ sub add_params_to_query ($request_ref, $query_ref) { | |||
| ) | |||
| ) | |||
| and ($tagtype !~ /^pnns_groups_/) | |||
There was a problem hiding this comment.
pnns_groups_1 / 2 can be included in @tagtype_allowing_unknown_as_value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Few tags like NOVA, Eco-Score and Nutri-Score can have an "unknown" value. Instead of looking for the presence or absence of the tag, we look for the value to be "unknown" (or not-applicable).
Screenshot
Related issue(s) and discussion