Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid crash in display_orgs_table when org.created_t is not set, fix permission #11203

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

stephanegigandet
Copy link
Contributor

fixes #11200

@stephanegigandet stephanegigandet requested a review from a team as a code owner January 7, 2025 14:38
@github-actions github-actions bot added the Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. label Jan 7, 2025
@stephanegigandet stephanegigandet changed the title fix: avoid crash when org.created_t is not set fix: avoid crash in display_orgs_table when org.created_t is not set, fix permission Jan 7, 2025
Copy link

sonarqubecloud bot commented Jan 7, 2025

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.18%. Comparing base (176fe9e) to head (7645afa).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11203      +/-   ##
==========================================
- Coverage   49.20%   49.18%   -0.02%     
==========================================
  Files          78       78              
  Lines       22380    22389       +9     
  Branches     5368     5371       +3     
==========================================
  Hits        11011    11011              
- Misses      10011    10020       +9     
  Partials     1358     1358              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephanegigandet stephanegigandet merged commit 765d796 into main Jan 7, 2025
16 checks passed
@stephanegigandet stephanegigandet deleted the fix-display-orgs-table branch January 7, 2025 16:17
alexgarel added a commit that referenced this pull request Jan 10, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.54.0](v2.53.0...v2.54.0)
(2025-01-10)


### Features

* gzip js, css, SVG icons assets
([#11208](#11208))
([c0a5275](c0a5275))


### Bug Fixes

* "NutriScore V2" SVGs with blank space
([#11218](#11218))
([38d79e8](38d79e8))
* avoid crash in display_orgs_table when org.created_t is not set, fix
permission
([#11203](#11203))
([765d796](765d796))
* greenscore attribute with old ecoscore_data
([#11212](#11212))
([4f596ad](4f596ad))
* Invalid OFF dark icon
([#11206](#11206))
([f63daa8](f63daa8))
* Nutripatrol url trailing slash removal regex
([#11204](#11204))
([f42f8dd](f42f8dd))
* Nutriscore for fresh herbs
([#11112](#11112))
([cdd7cf5](cdd7cf5))
* Remove irrelevant things in Config_obf.pm
([c5d448d](c5d448d))
* Remove irrelevant things in the Open Beauty Facts config
([#11195](#11195))
([c5d448d](c5d448d))
* remove warning in Display.pm related to Environmental Scoring
([#11172](#11172))
([176fe9e](176fe9e))
* Removing irrelevant fields in the Open Products Facts config
([4583ed2](4583ed2))
* Removing irrelevant fields in the Open Products Facts config
([#11202](#11202))
([4583ed2](4583ed2))
* typo in ecoscore redirect
([#11213](#11213))
([85fd575](85fd575))
* use ecoscore data when greenscore not available
([#11197](#11197))
([5ae1273](5ae1273))
* warnings in producers tests
([#11190](#11190))
([0588976](0588976))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Alex Garel <alex@openfoodfacts.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The dashboard of the Pro organisations is broken
3 participants