Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Nutri-Score for fresh herbs #11112

Merged
merged 11 commits into from
Jan 9, 2025
Merged

fix: Nutri-Score for fresh herbs #11112

merged 11 commits into from
Jan 9, 2025

Conversation

stephanegigandet
Copy link
Contributor

Fresh herbs need to be included in fruits/vegetables/legumes

from FAQ-updatedAlgo-EN_20240626.pdf:

The detailed list of the various foods qualifying in this component is available in Appendix 2.
The foods included in the following groups from the Eurocode 2 classification10 (in English) can be taken into
account for the calculation of the component:
-
In both the Original and the Updated Algorithms:
i. Group 7.10 (Pulses) (i.e. Legumes);
ii.Group 8.10 (Leaf vegetables); 8.15 (Brassicas); 8.20 (Stalk vegetables); 8.25 (Shoot vegetables); 8.30
(Onion-family vegetables); 8.38 (Root vegetables); 8.40 (Fruit vegetables); 8.45 (Seed vegetables and
immature pulses); 8.50 (Edible fungi); 8.55 (Seaweeds and algae); 8.60 (Vegetable mixtures)
iii Group 9.10 (Malaceous fruit); 9.20 (Prunus species fruit); 9.25 (Other stone fruit); 9.30 (Berries); 9.40 (Citrus
fruit); 9.50 (Miscellaneous fruit); 9.60 (Fruit mixtures).
iv Group 12.20 (Herbs)

@stephanegigandet
Copy link
Contributor Author

/update_tests_results

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis config 🚦 Nutri-Score labels Dec 11, 2024
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !

@alexgarel alexgarel enabled auto-merge (squash) December 13, 2024 10:03
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.22%. Comparing base (4583ed2) to head (dd6b2f8).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11112      +/-   ##
==========================================
+ Coverage   49.18%   49.22%   +0.04%     
==========================================
  Files          78       78              
  Lines       22389    22405      +16     
  Branches     5371     5374       +3     
==========================================
+ Hits        11011    11028      +17     
  Misses      10020    10020              
+ Partials     1358     1357       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon changed the title fix: Nutriscore for fresh herbs fix: Nutri-Score for fresh herbs Dec 30, 2024
Copy link

sonarqubecloud bot commented Jan 9, 2025

@alexgarel alexgarel merged commit cdd7cf5 into main Jan 9, 2025
14 checks passed
@alexgarel alexgarel deleted the nutriscore-herbs branch January 9, 2025 10:27
alexgarel added a commit that referenced this pull request Jan 10, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.54.0](v2.53.0...v2.54.0)
(2025-01-10)


### Features

* gzip js, css, SVG icons assets
([#11208](#11208))
([c0a5275](c0a5275))


### Bug Fixes

* "NutriScore V2" SVGs with blank space
([#11218](#11218))
([38d79e8](38d79e8))
* avoid crash in display_orgs_table when org.created_t is not set, fix
permission
([#11203](#11203))
([765d796](765d796))
* greenscore attribute with old ecoscore_data
([#11212](#11212))
([4f596ad](4f596ad))
* Invalid OFF dark icon
([#11206](#11206))
([f63daa8](f63daa8))
* Nutripatrol url trailing slash removal regex
([#11204](#11204))
([f42f8dd](f42f8dd))
* Nutriscore for fresh herbs
([#11112](#11112))
([cdd7cf5](cdd7cf5))
* Remove irrelevant things in Config_obf.pm
([c5d448d](c5d448d))
* Remove irrelevant things in the Open Beauty Facts config
([#11195](#11195))
([c5d448d](c5d448d))
* remove warning in Display.pm related to Environmental Scoring
([#11172](#11172))
([176fe9e](176fe9e))
* Removing irrelevant fields in the Open Products Facts config
([4583ed2](4583ed2))
* Removing irrelevant fields in the Open Products Facts config
([#11202](#11202))
([4583ed2](4583ed2))
* typo in ecoscore redirect
([#11213](#11213))
([85fd575](85fd575))
* use ecoscore data when greenscore not available
([#11197](#11197))
([5ae1273](5ae1273))
* warnings in producers tests
([#11190](#11190))
([0588976](0588976))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Alex Garel <alex@openfoodfacts.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories config 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🚦 Nutri-Score 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants