Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility mode: add back empty "" values for _serving and _100g for Android app #1763

Open
Tracked by #5523
stephanegigandet opened this issue May 10, 2019 · 1 comment
Open
Tracked by #5523

Compatibility mode: add back empty "" values for _serving and _100g for Android app #1763

stephanegigandet opened this issue May 10, 2019 · 1 comment
Labels
API READ All READ APIs include Product, Search… API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) 🤳🥫 blocking mobile apps This issues are blocking a feature on the Open Food Facts mobile apps

Comments

@stephanegigandet
Copy link
Contributor

Empty values like sugars_serving = "" were recently removed in the nutriments hash, but this causes issues in the current OFF android app. Adding them back temporarily, only when the user_agent is "Official Android App" or "okhttp" and the ?fields parameter is passed.

Should solve issue openfoodfacts/openfoodfacts-androidapp#2620
stephanegigandet pushed a commit that referenced this issue May 10, 2019
Add back empty '' values for _serving for OFF android app, bug #1763
1042b7e
@stephanegigandet
Copy link
Contributor Author

Deployed in production, remove at one point in the future when not needed anymore.

@teolemon teolemon added the API READ All READ APIs include Product, Search… label Jun 11, 2019
@teolemon teolemon added the API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) label Aug 21, 2021
@teolemon teolemon mentioned this issue Aug 21, 2021
Open
@teolemon teolemon added the 🤳🥫 blocking mobile apps This issues are blocking a feature on the Open Food Facts mobile apps label Apr 1, 2022
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
@teolemon teolemon added the 🐛 bug This is a bug, not a feature request. label Jul 19, 2024
@teolemon teolemon removed the 🐛 bug This is a bug, not a feature request. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API READ All READ APIs include Product, Search… API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) 🤳🥫 blocking mobile apps This issues are blocking a feature on the Open Food Facts mobile apps
Projects
🍊 Open Food Facts Server issues
Status: To discuss and validate
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Status: 💬 To discuss and validate
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teolemon @stephanegigandet