Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of quotes in ingredients list for ingredient parsing #1776

Closed
stephanegigandet opened this issue May 14, 2019 · 3 comments
Closed

Fix handling of quotes in ingredients list for ingredient parsing #1776

stephanegigandet opened this issue May 14, 2019 · 3 comments
Assignees
@stephanegigandet

Comments

@stephanegigandet
Copy link
Contributor

Related to #1769 : we currently have " in ingredients lists for ". The ingredient parser does not take this into account, which means we have ingredients like https://it.openfoodfacts.org/ingrediente/farina-di-grano-tenero-tipo-quot

We should fix the ingredient parser to handle " (until we implement storing the " directly in mongodb)
stephanegigandet pushed a commit that referenced this issue May 17, 2019
handle " escapes in ingredients, bug #1776
ef22aea
@sandy9999
Copy link
Contributor

What's the current state of this issue?

@VaiTon
Copy link
Member

VaiTon commented May 23, 2019

I think ef22aea should have closed it.

@hangy
Copy link
Member

hangy commented May 23, 2019

I think ef22aea should have closed it.

ACK.

@hangy hangy closed this as completed May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephanegigandet stephanegigandet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hangy @stephanegigandet @VaiTon @sandy9999