Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown Spanish ingredients that should be known #3625

Closed
Tracked by #9096 ...
AcuarioCat opened this issue Jun 14, 2020 · 12 comments · Fixed by #9846
Closed
Tracked by #9096 ...

Unknown Spanish ingredients that should be known #3625

AcuarioCat opened this issue Jun 14, 2020 · 12 comments · Fixed by #9846
Assignees
Labels
🐛 bug This is a bug, not a feature request. 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients processing Spanish ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.

Comments

@AcuarioCat
Copy link
Contributor

AcuarioCat commented Jun 14, 2020

What

  • I'm coming across several ingredients that should be recognized as their 'words' are in both ingredients and in ingredients_processing.
  • These are the ones I've found to date - I imagine there is a common root for this so it should provide the information necessary to fix the problem.
leche desnatada de vaca
aroma natural de naranja
jugo concentrado de piña
jugo de pasas

Part of

@AcuarioCat AcuarioCat added 🐛 bug This is a bug, not a feature request. 🥗 Ingredients 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis labels Jun 14, 2020
@aleene
Copy link
Contributor

aleene commented Jun 14, 2020

What is the issue with jugo de pasas?

@AcuarioCat
Copy link
Contributor Author

It doesn't get processed:
https://es.openfoodfacts.org/cgi/test_ingredients_analysis.pl?ingredients_text=jugo+de+pasas&type=add&action=process&.submit=Submit+Query

Returns es:jugo-de-pasas
Should return en:rasin-juice

@aleene
Copy link
Contributor

aleene commented Jun 14, 2020

Ah yes, it was not yet added to the latest update.(#3619)

By the way what is the difference between zumo and jugo, And should I separate them?

@aleene
Copy link
Contributor

aleene commented Jun 14, 2020

For the others, the question is what we do with processing adjectives hidden (in bwteen other words) in the ingredient. @stephanegigandet ?

@AcuarioCat
Copy link
Contributor Author

AcuarioCat commented Jun 14, 2020

Ah yes, it was not yet added to the latest update.(#3619)
By the way what is the difference between zumo and jugo, And should I separate them?

The difference is very subtle and partly one of regions. For example in South America everything is 'Jugo de' whereas in Spain it tends to be Zumo when referring to fruit/vegetable and jugo when referring to juices of (for example) meat.

My wife (Spanish) says jugo refers more to something that comes out of something when cooked (jugo de carne) and zumo when it is squeezed/pressed (zoom de naranja).

I think that they are so similar and interchangeable that you don't need to worry and that you will come across both, however both need to be recognized.

..and just to make things even more interesting, when referring to 'jugo' it can also be 'caldo' but definitely Not when referring to zumo. So, jugo de verduras, caldo de verduras (which is more typical) but definitely NOT zumo de verduras.

@aleene
Copy link
Contributor

aleene commented Jun 14, 2020

The region thing makes it more difficult. I know other languages that differentiate between spanish jugo/zumo as well. Sounds like zumo is the more specific one, we can that make a child of jugo.

@AcuarioCat
Copy link
Contributor Author

At the moment I have them listed as synonyms at the top of ingredients.txt

@AcuarioCat
Copy link
Contributor Author

Here is an additional entry from 8480017680389
extracto vegetal colorante

@AcuarioCat
Copy link
Contributor Author

AcuarioCat commented Jun 18, 2020

It's improving a lot but still not quite there.
The following aren't getting processed:

aroma natural de naranja
caldo deshidratado de vegetales
puré de hortalizas

@aleene
Copy link
Contributor

aleene commented Jun 18, 2020

Is not working in french either.

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Jan 16, 2021
@teolemon teolemon added Spanish and removed ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. labels Jul 19, 2021
@teolemon teolemon moved this to To do in Ingredient analysis Jun 25, 2022
Copy link
Contributor

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Feb 24, 2024
@stephanegigandet
Copy link
Contributor

The only case that is not working yet is "caldo deshidratado de vegetales".

Maybe we could relax the ingredient processing so that it can match inside the ingredient string (and not only at the beginning and end).

https://es.openfoodfacts.org/cgi/test_ingredients_analysis.pl?ingredients_text=leche+desnatada+de+vaca%2C%0D%0Aaroma+natural+de+naranja%2C%0D%0Ajugo+concentrado+de+pi%C3%B1a%2C%0D%0Ajugo+de+pasas%2C%0D%0Acaldo+deshidratado+de+vegetales%2C%0D%0Apur%C3%A9+de+hortalizas%2C&type=add&action=process&submit=Envoyer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug This is a bug, not a feature request. 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients processing Spanish ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants