Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the API to request a sample product with code=example #6250

Closed
stephanegigandet opened this issue Jan 6, 2022 · 0 comments · Fixed by #6252
Closed

Allow the API to request a sample product with code=example #6250

stephanegigandet opened this issue Jan 6, 2022 · 0 comments · Fixed by #6252
Assignees
@stephanegigandet
Labels
API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) ✨ Feature Features or enhancements to Open Food Facts server

Comments

@stephanegigandet
Copy link
Contributor

Is your feature request related to a problem? Please describe.

For apps that want to display a sample product.

Describe the solution you'd like

Just passing "example" as the barcode in the code field. That way the existing API and SDKs can be used without modifications, and we can decide server side what to do:

  • either return a real, existing product, possibly dependent on the language and/or country requested through the API
  • or return a fake product

Describe alternatives you've considered

No response

Additional context

No response

Number of products impacted

No response

Time per product

No response
@stephanegigandet stephanegigandet added ✨ Feature Features or enhancements to Open Food Facts server API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) labels Jan 6, 2022
@stephanegigandet stephanegigandet self-assigned this Jan 6, 2022
@stephanegigandet stephanegigandet mentioned this issue Jan 6, 2022
Merged
stephanegigandet added a commit that referenced this issue Jan 6, 2022
@stephanegigandet
feat: example product in API with code=example - #6250
0070935
@stephanegigandet stephanegigandet mentioned this issue Jan 6, 2022
Merged
stephanegigandet added a commit that referenced this issue Jan 6, 2022
@stephanegigandet
feat: example product in API with code=example - #6250 (#6252)
c0605a4
@github-actions github-actions bot mentioned this issue Jan 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephanegigandet stephanegigandet

Labels
API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) ✨ Feature Features or enhancements to Open Food Facts server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: example product in API with code=example openfoodfacts/openfoodfacts-server
1 participant
@stephanegigandet