-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CSV / XSLX exports to have 1 export format (and code) instead of 3 #6424
Comments
My plan is to first start to make the on demand search export on the website use the code from Export.pm. The search export is requested manually, so it's probably not a big issue if we change which columns are included and their names. Once we have something that we are happy with, we can look into replacing the full database CSV export, probably in a new location, so that we don't break things. |
Convergence of exports is a real big plus. When refactoring, I think it would be great to separate processing into map like structure, from rendering to xls. My only small concern is that for communication between producer and public platform, I would go away from the csv/xls format… because it seems to me that in introduces some tweaks that are not useful. |
* new misc facet values for Eco-Score missing packaging warning * more ecoscore missing data facets * update tests * refactor on demand csv/xlsx export on website - wip * export off derived fields * export Eco-Score data * prefix off computed fields by off:, add _tags fields * fix filehandle * add tests for CSV exports #6424 * Update labeler.yml * start mongodb * update tests * remove condition on hardcoded domain name * feat: add missing_key_data flag to ecoscore * export more ecoscore fields * fix tests * Update lib/ProductOpener/Export.pm Co-authored-by: Alex Garel <alex@garel.org> * Update t/export.t Co-authored-by: Alex Garel <alex@garel.org> * suggestions from code review * create Test.pm module * create Test.pm module Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org> Co-authored-by: Alex Garel <alex@garel.org>
This issue is stale because it has been open 90 days with no activity. |
Is your feature request related to a problem? Please describe.
We currently have 3 different CSV exports, each with different fields, and with different code:
Describe the solution you'd like
Gradually converge to 1 common format and 1 single code base (Export.pm).
Desirable features:
Additional context
Related issues:
The text was updated successfully, but these errors were encountered: