Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect data from producer should be the default setting when creating an organization #6526

Closed
2 tasks
alexgarel opened this issue Mar 30, 2022 · 2 comments · Fixed by #7845 or #7781
Closed
2 tasks
Assignees
Labels
🐛 bug This is a bug, not a feature request. 🎯 P0 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers ⭐ 🐛 top bug Top bug.

Comments

@alexgarel
Copy link
Member

Describe the bug

We have a "Protect the data that is provided by the organization." settings which is not set by default, while we insure producers that their data is protected for one year.

To Reproduce

  1. Create a new producer account for a new org
  2. Go to pro platform as admin
  3. Select the new org
  4. Edit the profile
  5. The setting is not set

Expected behavior

It should be set by default, at org creation

Having it as a setting might be useful in the case where data published by a org reveals to be fake or some other scenario (moral contract is broken). But this is a rare case, so it should be checked by default and unchecked when needed.

  • change the org creation code to have it set
  • write a migrate script for existing org and run it

Screenshots

No response

Additional context

No response

Type of device

Browser

Browser version

No response

Number of products impacted

No response

Time per product

No response

@alexgarel alexgarel added 🐛 bug This is a bug, not a feature request. 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers 🎯 P0 labels Mar 30, 2022
@alexgarel alexgarel self-assigned this Mar 30, 2022
@stephanegigandet stephanegigandet changed the title Protect data from producer should be Protect data from producer should be the default setting when creating an organization Mar 30, 2022
@alexgarel alexgarel moved this to Sprint (in priority order, max 10) in 🍊 Open Food Facts Server issues May 23, 2022
@stephanegigandet stephanegigandet moved this to 🔖 Sprint (max 10) in Product Opener - Sprint May 30, 2022
@stephanegigandet stephanegigandet moved this from 🔖 Sprint (max 10) to 📋 Shortlist (max 20) in Product Opener - Sprint Jun 13, 2022
@github-actions github-actions bot added the ⭐ 🐛 top bug Top bug. label Sep 20, 2022
@github-actions github-actions bot removed the ⭐ 🐛 top bug Top bug. label Nov 2, 2022
@github-actions github-actions bot added the ⭐ 🐛 top bug Top bug. label Nov 19, 2022
alexgarel added a commit that referenced this issue Dec 15, 2022
* it is now the default on org creation
* added a migration script

fixes: #6526
alexgarel added a commit that referenced this issue Dec 15, 2022
* it is now the default on org creation
* added a migration script

fixes: #6526
@alexgarel alexgarel moved this from 📋 Shortlist (max 20) to 🔖 Sprint (max 10) in Product Opener - Sprint Dec 15, 2022
alexgarel added a commit that referenced this issue Dec 16, 2022
* fix: org should have data protected by default

* it is now the default on org creation
* added a migration script

fixes: #6526
Repository owner moved this from To do to Done in 🏭 Producers Platform Dec 16, 2022
Repository owner moved this from Sprint (in priority order, max 10) to Done in 🍊 Open Food Facts Server issues Dec 16, 2022
@alexgarel
Copy link
Member Author

We still have to run the script in staging (to test it) and in production.

@alexgarel alexgarel reopened this Dec 16, 2022
Repository owner moved this from Done to In Progress in 🍊 Open Food Facts Server issues Dec 16, 2022
Repository owner moved this from Done to In progress in 🏭 Producers Platform Dec 16, 2022
@alexgarel alexgarel moved this from 🔖 Sprint (max 10) to 🏗 In progress in Product Opener - Sprint Dec 16, 2022
@github-project-automation github-project-automation bot moved this from In progress to Done in 🏭 Producers Platform Jan 24, 2023
@manon-corneille
Copy link
Contributor

manon-corneille commented Mar 17, 2023

Am I understanding that this works now ? :)
If yes, should we close this issue too ? → #2086

@alexgarel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug This is a bug, not a feature request. 🎯 P0 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers ⭐ 🐛 top bug Top bug.
Projects
Status: 🏗 In progress
Status: Done
3 participants