Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import GS1 product data from Agena3000 #6537

Closed
Tracked by #5521
stephanegigandet opened this issue Apr 1, 2022 · 2 comments
Closed
Tracked by #5521

Import GS1 product data from Agena3000 #6537

stephanegigandet opened this issue Apr 1, 2022 · 2 comments
Assignees
@stephanegigandet
Labels
Data import ✨ Feature Features or enhancements to Open Food Facts server GS1 The producer platform is integrating with the GS1 product data formats. GS1 manages barcodes. 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.

Comments

@stephanegigandet
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Agena3000 is a GS1 datapool (similar to Equadis) which is going to allow its customers (manufacturers) to send us product data in the GS1 format.

Describe the solution you'd like

We already have some code to process GS1 data for Equadis and CodeOnline, but there maybe subtle differences in the format and/or the data.

Compared to other GS1 imports, we will need to generate confirmation messages in the GS1 format (CIC)

We also will need to implement some plumbing to automate the import.

Describe alternatives you've considered

No response

Additional context

No response

Number of products impacted

No response

Time per product

No response
@stephanegigandet stephanegigandet added ✨ Feature Features or enhancements to Open Food Facts server Data import 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers GS1 The producer platform is integrating with the GS1 product data formats. GS1 manages barcodes. labels Apr 1, 2022
@stephanegigandet stephanegigandet self-assigned this Apr 1, 2022
stephanegigandet added a commit that referenced this issue Apr 4, 2022
@stephanegigandet
1 GS1 message can contain several products #6537
c48d196
stephanegigandet added a commit that referenced this issue Apr 4, 2022
@stephanegigandet
1 GS1 message can contain several products #6537
9ff3643
stephanegigandet added a commit that referenced this issue Apr 8, 2022
@stephanegigandet @alexgarel
feat: Improvements to GS1 imports to prepare integration of Agena3000 (…
ce4eb51 
…#6566)

* update label logos #5239

* equadis message with nested products

* add more GS1 tests files

* try to use Perl XML::XML2JSON instead of nodejs xml2json

* more comments and small fix

* 1 GS1 message can contain several products #6537

* 1 GS1 message can contain several products #6537

* update tests

* added carrying bag (GS1 PUG)

* added carrying bag (GS1 PUG)

* update tests

* more comments and doc

* rename script

* more comments and doc

* move/rename equadis-xml2json.js script

* fix lint issues

* predeclare recursive functions

* import -> require

* Update lib/ProductOpener/GS1.pm

Co-authored-by: Alex Garel <alex@garel.org>

* Update lib/ProductOpener/GS1.pm

Co-authored-by: Alex Garel <alex@garel.org>

* Update scripts/convert_gs1_xml_to_json_in_dir.pl

Co-authored-by: Alex Garel <alex@garel.org>

* add missing ;

* fix lint issue

* fix lint issue

Co-authored-by: off <off@openfoodfacts.org>
Co-authored-by: Alex Garel <alex@garel.org>
@stephanegigandet stephanegigandet mentioned this issue Apr 11, 2022
Merged
stephanegigandet added a commit that referenced this issue Apr 15, 2022
@stephanegigandet
feat: add support for 2 GS1 quantityContained field in nutrientDetail #…
94898bb 
…6537
stephanegigandet added a commit that referenced this issue Apr 15, 2022
@stephanegigandet
feat: add support for 2 GS1 quantityContained field in nutrientDetail #…
637cc81 
…6537
@stephanegigandet stephanegigandet mentioned this issue Apr 15, 2022
Merged
stephanegigandet added a commit that referenced this issue Apr 22, 2022
@stephanegigandet
feat: add support for 2 GS1 quantityContained field in nutrientDetail #…
f6c2678 
…6537 (#6630)
@alexgarel alexgarel mentioned this issue Apr 22, 2022
Merged
@stephanegigandet stephanegigandet mentioned this issue May 10, 2022
Merged
@stephanegigandet stephanegigandet moved this to 🏗 In progress in Product Opener - Sprint May 30, 2022
@stephanegigandet stephanegigandet moved this from 🏗 In progress to To verify (preprod) in Product Opener - Sprint Jun 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022

This issue is stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Jul 4, 2022
@stephanegigandet
Copy link
Contributor Author

This has been deployed on the pro platform.

Repository owner moved this from In Progress to Done in 🍊 Open Food Facts Server issues Jul 4, 2022
@stephanegigandet stephanegigandet moved this from To verify (preprod) to ✅ Done in Product Opener - Sprint Jul 4, 2022
@teolemon teolemon mentioned this issue Feb 14, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephanegigandet stephanegigandet

Labels
Data import ✨ Feature Features or enhancements to Open Food Facts server GS1 The producer platform is integrating with the GS1 product data formats. GS1 manages barcodes. 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
Projects
Product Opener - Sprint
Archived in project
🍊 Open Food Facts Server issues
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teolemon @stephanegigandet