feat: Agena3000 integration #6594
Conversation
stephanegigandet
added
the
🏭 Producers Platform
github-actions
bot
added
Data import
Display
Products
Template::Toolkit
lib/ProductOpener/Images.pm
Outdated
| if ($file =~ /\.($extensions)$/i) { | ||
| $extension = lc($1) ; | ||
| } | ||
| if ($file =~ /\.($extensions)$/i) { |
There was a problem hiding this comment.
renaming $extensions to $supported_extensions would help improve readability.
There was a problem hiding this comment.
sure, will do
| my $filename = get_string_id_for_lang("no_language", remote_addr(). '_' . $`); | ||
| } | ||
|
|
||
| my $filename = get_string_id_for_lang("no_language", remote_addr(). '_' . $`); |
There was a problem hiding this comment.
can you add a comment ? I don't understand what we do here…
There was a problem hiding this comment.
I'll add a comment, it's just a name for a temporary file, prefixed with the user ip address + a normalized version of the original file name uploaded by the user
| $lock_path = "$product_www_root/images/products/$path/$imgid.lock"; | ||
| } | ||
| my $lock_path = "$product_www_root/images/products/$path/$imgid.lock"; | ||
| while ((-e $lock_path) or (-e "$product_www_root/images/products/$path/$imgid.jpg")) { |
There was a problem hiding this comment.
can't we first search for max imgid already present, to avoid a long check on files (in my experience it can really degrade perfs)
There was a problem hiding this comment.
can't we first search for max imgid already present
withlsI mean
There was a problem hiding this comment.
sure we could do that
|
|
||
| rm -rf /srv2/off-pro/agena3000-data-tmp | ||
| mkdir /srv2/off-pro/agena3000-data-tmp | ||
| find /home/sftp/agena3000/RECETTE/Fiches/ -mtime -2 -type f -exec cp {} /srv2/off-pro/agena3000-data-tmp/ \; |
There was a problem hiding this comment.
to be sure not to miss an export, another way is to touch a file at the end, and use find with -newer
And if the file does not yet exists fallback to 2 days.
Co-authored-by: Alex Garel <alex@garel.org>
|
Kudos, SonarCloud Quality Gate passed!
|
Part of #6537