Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: "Dry" not being recognized as a processing type #6636

Merged
merged 2 commits into from
Apr 17, 2022
Merged

fix: "Dry" not being recognized as a processing type #6636

merged 2 commits into from
Apr 17, 2022

Conversation

yuktea
Copy link
Contributor

@yuktea yuktea commented Apr 17, 2022 •
edited
Loading

Description

  • Added a test that would verify when the fix has been implemented.
  • Added dry as a secondary word for dried

Screenshot

image

Related issue(s) and discussion

@yuktea yuktea requested a review from a team as a code owner April 17, 2022 10:55
@yuktea yuktea changed the title fix: Add test to replicate the issue with "Dry" not being recognized as a processing type fix: "Dry" not being recognized as a processing type Apr 17, 2022
@github-actions github-actions bot added the 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies label Apr 17, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

stephanegigandet
stephanegigandet approved these changes Apr 17, 2022
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@stephanegigandet stephanegigandet merged commit 554f69a into main Apr 17, 2022
@stephanegigandet stephanegigandet deleted the add-dry-as-word-for-dried branch April 17, 2022 13:53
@alexgarel alexgarel mentioned this pull request Apr 17, 2022
Merged
@ditsuke ditsuke mentioned this pull request Apr 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees
No one assigned
Labels
🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
🍊 Open Food Facts Server issues
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuktea @stephanegigandet