Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to have knowledge panels collapsed in the app but not on the website (list of ingredients + nutrition table) #6786

Closed
stephanegigandet opened this issue May 16, 2022 · 2 comments · Fixed by #6834 or #6801
Closed

Add a way to have knowledge panels collapsed in the app but not on the website (list of ingredients + nutrition table) #6786

stephanegigandet opened this issue May 16, 2022 · 2 comments · Fixed by #6834 or #6801
Assignees
@alexgarel
Labels
✨ Feature Features or enhancements to Open Food Facts server 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels 🎯 P0
Milestone
Smoothie Launch (...

Comments

@stephanegigandet
Copy link
Contributor

stephanegigandet commented May 16, 2022 •
edited by teolemon
Loading

What

Add a way to have knowledge panels collapsed in the app but not on the website (list of ingredients + nutrition table)

Part of
@stephanegigandet stephanegigandet added ✨ Feature Features or enhancements to Open Food Facts server 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels labels May 16, 2022
@stephanegigandet stephanegigandet moved this from Todo to Sprint (in priority order, max 10) in 🍊 Open Food Facts Server issues May 16, 2022
@alexgarel alexgarel removed ✨ Feature Features or enhancements to Open Food Facts server 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels labels May 16, 2022
@teolemon teolemon added ✨ Feature Features or enhancements to Open Food Facts server 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels labels May 16, 2022
@teolemon teolemon mentioned this issue May 20, 2022
Closed
1 task
@alexgarel
Copy link
Member

@stephanegigandet for this, my proposal would be:

  • pass expended to false
  • add a property expand_for: with a list of device size (eg: large) (alternatively it cloud also be device type like "web")
  • modify the web rendering to take expand_for into account (as first implementation, we will always consider we are large)

@stephanegigandet
Copy link
Contributor Author

@alexgarel That sounds perfect to me. Using device size is a very good idea I think, on mobile web it certainly makes sense to have less things expanded by default. I'm not sure how easy it will be to make it work with Foundation on the web, but it doesn't matter, in a first iteration, we can just web = large, and we can figure it out later.

alexgarel added a commit that referenced this issue May 30, 2022
@alexgarel
feat: expand some panels only on large devices
78b4c69 
for now web is always considered large, but we have a specific class we could play upon.
Applied to nutrition and ingredients panels

fixes #6786
@alexgarel alexgarel mentioned this issue May 30, 2022
Merged
@alexgarel alexgarel moved this from Sprint (in priority order, max 10) to In Progress in 🍊 Open Food Facts Server issues May 30, 2022
@alexgarel alexgarel self-assigned this May 30, 2022
stephanegigandet pushed a commit that referenced this issue May 30, 2022
@alexgarel
feat: expand some panels only on large devices (#6834)
6331777 
for now web is always considered large, but we have a specific class we could play upon.
Applied to nutrition and ingredients panels

fixes #6786
Repository owner moved this from In Progress to Done in 🍊 Open Food Facts Server issues May 30, 2022
@alexgarel alexgarel mentioned this issue May 30, 2022
Merged
@stephanegigandet stephanegigandet moved this from ✅ Done to To verify (preprod) in Product Opener - Sprint May 30, 2022
@stephanegigandet stephanegigandet moved this from To verify (preprod) to ✅ Done in Product Opener - Sprint Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexgarel alexgarel

Labels
✨ Feature Features or enhancements to Open Food Facts server 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels 🎯 P0
Projects
Product Opener - Sprint
Archived in project
🍊 Open Food Facts Server issues
Archived in project
📖 Knowledge panels
Status: To do
Milestone
Smoothie Launch (server readiness)
3 participants
@alexgarel @teolemon @stephanegigandet