Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add title to ingredients panel and nutrition facts table panel #6835

Closed
stephanegigandet opened this issue May 30, 2022 · 0 comments · Fixed by #6839 or #6801
Closed

Add title to ingredients panel and nutrition facts table panel #6835

stephanegigandet opened this issue May 30, 2022 · 0 comments · Fixed by #6839 or #6801
Assignees
@alexgarel
Labels
🐛 bug This is a bug, not a feature request.

Comments

@stephanegigandet
Copy link
Contributor

Describe the bug

PR #6834 collapses the ingredients and nutrition facts knowledge panels on mobile, but the panels do not have titles, so it's not possible to expand them.

To Reproduce

Load a product in the new app.

Expected behavior

Add a clickable panel to expand the list of ingredients and nutrition facts table.

Possibly:

  • Add an icon
  • Add the number of ingredients in the title "54 ingredients ->"

Screenshots

No response

Additional context

No response

Type of device

REST-API

Browser version

No response

Number of products impacted

No response

Time per product

No response
@stephanegigandet stephanegigandet added the 🐛 bug This is a bug, not a feature request. label May 30, 2022
@alexgarel alexgarel self-assigned this May 30, 2022
@stephanegigandet stephanegigandet moved this to 🔖 Sprint (max 10) in Product Opener - Sprint May 30, 2022
@alexgarel alexgarel moved this from 🔖 Sprint (max 10) to 🏗 In progress in Product Opener - Sprint May 30, 2022
alexgarel added a commit that referenced this issue May 31, 2022
@alexgarel
fix: ingredients and nutrition should have titles
9dde734 
because we made them collapsable.

fixes: #6835
@alexgarel alexgarel mentioned this issue May 31, 2022
Merged
alexgarel added a commit that referenced this issue Jun 2, 2022
@alexgarel
fix: ingredients and nutrition should have titles (#6839)
8048013 
* fix: ingredients and nutrition should have titles

because we made them collapsible.

fixes: #6835
@alexgarel alexgarel moved this from 🏗 In progress to To verify (preprod) in Product Opener - Sprint Jun 2, 2022
@alexgarel alexgarel mentioned this issue Jun 2, 2022
Merged
@stephanegigandet stephanegigandet moved this from To verify (preprod) to ✅ Done in Product Opener - Sprint Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexgarel alexgarel

Labels
🐛 bug This is a bug, not a feature request.
Projects
Product Opener - Sprint
Archived in project
Milestone
No milestone
2 participants
@alexgarel @stephanegigandet