-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refresh the Nutri-Score and Eco-Score logos #6848
Conversation
For the not applicable Eco-Score and Nutri-Score logos, I made them lighter (so less visible) than the unknown versions. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, but the nutriscore unknown, I prefer the old version with "?" (on eco-score we have the "?"). Why not keep the "?".
I like the not applicable versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I validate because my objection is maybe a matter of taste.
This PR replaces #6830
The Nutri-Score logos are exactly the ones from https://www.santepubliquefrance.fr/media/files/02-determinants-de-sante/nutrition-et-activite-physique/nutri-score/annexe2-charte-graphique
Their default size is set to 240x130 px (like the previous logos).
The new Eco-Score logos are also 240x130. They are almost the same as the ones created by Quentin in https://www.figma.com/file/nFMjewFAOa8c4ahtob7CAB/Mobile-App-Design-(Quentin)
The difference is the size, they are slightly longer, so that we can have the exact same size as the Nutri-Score logos.
Small view:
Large view: