Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refresh the Nutri-Score and Eco-Score logos #6848

Merged
merged 2 commits into from
Jun 3, 2022

Conversation

stephanegigandet
Copy link
Contributor

This PR replaces #6830

The Nutri-Score logos are exactly the ones from https://www.santepubliquefrance.fr/media/files/02-determinants-de-sante/nutrition-et-activite-physique/nutri-score/annexe2-charte-graphique

Their default size is set to 240x130 px (like the previous logos).

The new Eco-Score logos are also 240x130. They are almost the same as the ones created by Quentin in https://www.figma.com/file/nFMjewFAOa8c4ahtob7CAB/Mobile-App-Design-(Quentin)
The difference is the size, they are slightly longer, so that we can have the exact same size as the Nutri-Score logos.

Small view:

image

Large view:

image

@stephanegigandet
Copy link
Contributor Author

For the not applicable Eco-Score and Nutri-Score logos, I made them lighter (so less visible) than the unknown versions.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, but the nutriscore unknown, I prefer the old version with "?" (on eco-score we have the "?"). Why not keep the "?".

I like the not applicable versions.

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I validate because my objection is maybe a matter of taste.

@stephanegigandet
Copy link
Contributor Author

I liked the version with the ? too (I'm biased, I created it ;) )

But the Nutri-Score charter states that we should use their neutral logos without a question mark:

image

@stephanegigandet stephanegigandet merged commit a677457 into main Jun 3, 2022
@stephanegigandet stephanegigandet deleted the nutri-eco-logos branch June 3, 2022 08:45
@teolemon teolemon added 🌱 Green-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products 🚦 Nutri-Score labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 Green-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products 🚦 Nutri-Score
Projects
Archived in project
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants